⚡️ uint8array set method instead of spread #1667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvnsrzn
changed the title
vvnsrzn
force-pushed
the
perf-xet-fetchdata
branch
from
38b42c8 to
028f861
Compare
coyotte508
reviewed
Aug 25, 2025
| @@ -327,8 +327,11 @@ export class XetBlob extends Blob { | |||
| totalFetchBytes += result.value.byteLength; | |||
|
|
|||
| if (leftoverBytes) { | |||
| result.value = new Uint8Array([...leftoverBytes, ...result.value]); | |||
| leftoverBytes = undefined; | |||
There was a problem hiding this comment.
I think the leftoverBytes = undefined part is important
There was a problem hiding this comment.
can you also make the function into a combineUint8Arrays helper? ( a dedicated file in this folder)
There was a problem hiding this comment.
Of course, I'll take care of it.
vvnsrzn
force-pushed
the
perf-xet-fetchdata
branch
2 times, most recently
from
7a7e64f to
699b51a
Compare
|
some formatting issues, you can run |
vvnsrzn
force-pushed
the
perf-xet-fetchdata
branch
from
4540655 to
688dd77
Compare
Oh sorry for that, I didn't run the right command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @coyotte508
I stumbled upon this issue.
I suggest to use the set method instead.
Benchmark: https://jsben.ch/jze3P